Re: [Xen-devel] [PATCH] Fix rename issue of xm dump-core

[Alastair Tse <atse@xxxxxxxxxxxxx>]

Yes, I think that patch makes a a lot of sense. There is an  
unnecessary getopt import and the exceptions need to be caught and  
reported appropriately.
I'll apply this patch shortly.

Cheers,

Alastair


On 23 Sep 2006, at 05:50, Masaki Kanno wrote:

> Hi Alastair,
>
> Thanks for your modification.
>
> I sent a bug fix patch one more about xm dump-core command.
> Could you apply it?
>
> http://lists.xensource.com/archives/html/xen-devel/2006-09/ 
> msg00532.html
> Best reagrds,
>  Kan
>
> > On Tue, 2006-09-19 at 21:37 +0900, Masaki Kanno wrote:
> > > This patch fixes this issue, and shows an error message.
> > >
> > > # xm dump-core vm1 /xen/dump
> > > dumping core of domain:vm1 ...
> > > Error: core dump failed: (21, 'Is a directory')
> > Rather than handling the core dump failure for a directory with a
> > special case, I've added a check before the dump to make sure the  
> > file
> > name supplied is not a directory.
> >
> > Thanks,
> >
> > Alastair
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel