WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Sysfs Interface for balloon driver

To: Satoshi Uchida <s-uchida@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Sysfs Interface for balloon driver
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Wed, 20 Sep 2006 02:12:35 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 19 Sep 2006 18:13:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <007c01c6dc4b$72ca3430$4c87380a@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <007c01c6dc4b$72ca3430$4c87380a@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Sep 20, 2006 at 09:26:43AM +0900, Satoshi Uchida wrote:

>     [root@Dom0 ~]# cat /sys/bus/xen/drivers/balloon/statistics/balloon_high
>           0 kB

It's very unusual to have units in a sysfs node. I believe this should
just be the number, and documented elsewhere what the units are.

I also don't quite get the location. I don't quite think of balloon as a
real "driver" as such, it's core kernel functionality rather. Wouldn't
/sys/hypervisor/properties/balloon/ be a more sensible place?

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel