This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] clear cpu_eoi_map bit on flush

To: Steven Rostedt <srostedt@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] clear cpu_eoi_map bit on flush
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 23 Aug 2006 11:32:20 +0100
Delivery-date: Wed, 23 Aug 2006 03:32:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44EBCC25.4030704@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbGn2mTqBuTlDKSEduhlQAKle7CWA==
Thread-topic: [Xen-devel] [PATCH] clear cpu_eoi_map bit on flush
User-agent: Microsoft-Entourage/

On 23/8/06 4:31 am, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:

> When cpu_eoi_map is set, neither flush_all_pending_eoi nor
> flush_read_eoi clear the cpu_eoi_map bit.  So I hit the BUG_ON.
> I haven't put too much effort into this patch, but it seems that it gets
> me past the problem I was having. (I'm now crashing later on in Dom0 but
> that's my problem :)
> I added the ASSERT because it seems that that bit should be set
> regardless. Thinking that pending_eoi_sp should be in sync with
> cpu_eoi_map (but I could be wrong on this).

That part of the unbind routine is actually much more heavyweight than we
really need, so I cut it back and added a more detailed comment for future
reference. I think your patch was fine though, except that you forgot to add
the missing 'peoi[sp].ready = 0'.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>