WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][vTPM] 3/3: TPM device model for qemu dm

To: "Stefan Berger" <stefanb@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][vTPM] 3/3: TPM device model for qemu dm
From: "Christian Limpach" <christian.limpach@xxxxxxxxx>
Date: Tue, 22 Aug 2006 09:42:05 +0100
Cc: safford@xxxxxxxxxxxxxx, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, christian.limpach@xxxxxxxxxxxxx
Delivery-date: Tue, 22 Aug 2006 01:42:36 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=gHO9R1L57veY87nSwSwYAiz4Ph6RQY/LwI9Lljw9w8HsrdR8TEdGFGQrAPjRBbXntdxMHNyBimdA0nVrYW+QhXnEo/nhMpHVU/sQjaBeG/Mlt+69XwKgXaM0QiPFv+u54KzRgjfN7XeYjCYCgVOpcKArx4CvRB8LPvMUQYr7G/k=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1156171860.8371.39.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1156171860.8371.39.camel@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: Christian.Limpach@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 8/21/06, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
This patch adds a TPM device model to the qemu dm for fully virtualized
VMs. It is enabled in the VM only if the user requests a TPM device in
the vm configuration file using the 'vtpm=[...]' line. It enables the
qemu device model command line with a 'vtpm_instance <instance number>'
parameter.

Isn't the vtpm instance stored in xenstore anyway?  If so, then please
add code to ioemu's xenstore.c to read it from there instead of adding
a command line switch.  We're moving away from command line switches
for device configuration.

Minor nitpicks:
- don't use extern to access global variables, add them to vl.h instead.
- add tpm.c to VL_OBJS on a separate line, makes merging it much easier.

   christian


Signed-off-by: David Safford <safford@xxxxxxxxxxxxxx>
Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>