 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] PATCH: multicall and auto_translated in netfront.c
| To: | Steven Smith <sos22-xen@xxxxxxxxxxxxx>, Tristan Gingold <Tristan.Gingold@xxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] PATCH: multicall and auto_translated in netfront.c |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Sat, 19 Aug 2006 10:32:22 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, sos22@xxxxxxxxxxxxx |
| Delivery-date: | Sat, 19 Aug 2006 02:41:17 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20060818173001.GA5829@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcbDcl9ZneC4li9lEdu36QANk04WTA== |
| Thread-topic: | [Xen-devel] PATCH: multicall and auto_translated in netfront.c |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 18/8/06 6:30 pm, "Steven Smith" <sos22-xen@xxxxxxxxxxxxx> wrote: > The intent of this code was that pages_done should be 0 if > auto_translated_physmap was set, so this should be a no-op. It gets > initialised to 0 at the top of the big loop, and is then only modified > by xennet_get_responses through its mcl_offset_p pointer. > xennet_get_responses only modifies it if > !xen_feature(XENFEAT_auto_translated_physmap). Am I simply confused? That's how the code looks to me too. In fact this means there is a bug, because driver allowance does not get properly decremented (it is incremented even for auto-translated guests in alloc_rx_buffers). I've checked in some cleanup as c/s 11199. It explicitly makes the multicall dependent on !auto_translated, so it should simply never be executed on ia64. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] RE: [PATCH] Paravirtual framebuffer use xvc for xenconsole [4/6], Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [patch 5/6] frontend device shutdown, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] PATCH: multicall and auto_translated in netfront.c, Steven Smith |
| Next by Thread: | Re: [Xen-devel] PATCH: multicall and auto_translated in netfront.c, Tristan Gingold |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
