This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/3] tools/xm-test: add cpus parm test in create

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/3] tools/xm-test: add cpus parm test in create bucket
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Wed, 16 Aug 2006 09:27:52 -0500
Cc: Ryan Harper <ryanh@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 16 Aug 2006 07:29:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1089FCC.F04%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060814173753.GN1694@xxxxxxxxxx> <C1089FCC.F04%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> [2006-08-16 04:13]:
> On 14/8/06 6:37 pm, "Ryan Harper" <ryanh@xxxxxxxxxx> wrote:
> >> Do these tests succeed even if, e.g. The test machine has only one CPU? Xen
> >> will clip the cpumasks when it receives them (also it will fail the
> >> set_affinity call if none of the specified CPUs are online) but this may 
> >> not
> >> matter if the affinity data is cached within xend and getVcpuInfo obtains
> >> info from that cache.
> > 
> > Good question.  I'll check and resend this test with the smp level check
> > so this test will be skipped if the host is not smp capable.
> Either this test will work on UP just fine, so no need for any extra checks,
> or it will need a more sophisticated check than SMP-vs-UP. What if you have
> a quad test box (you refer to cpus up to 7)?

As long as the first cpu in the mask is available then the affinity
settings will succeed.  In my current revision of the test I examined the
number of vcpus in the test strings but I think instead I'll examine all
of the test strings and compare the first value of every set.  The max
of those values is the minimum number of cpus needed since xen will pin
the vcpu to the first bit in the affinity mask.

Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253

Xen-devel mailing list