[Xen-devel] Re: [NET] front: Fix features on resume when csum is

On Wed, Aug 16, 2006 at 02:00:02PM +0100, Keir Fraser wrote:
> 
> This seems a bit odd. Shouldn't it be up to the network stack to not use
> SG/TSO if it can't use them with a non-checksumming interface? What is the
> failure mode currently?

As it is it's the partly the responsibility of the drivers to maintain
the consistency of the features set.  The network stack assists this
task by turning off SG/TSO when TX checksum is turned off through
ethtool.  It also ensures that when the user tries to enable SG/TSO
that TX checksum must be enabled.

In this case, SG/TSO is being turned on by the driver (as opposed to
the user) so the driver needs to ensure that TX checksum is supported.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Keir Fraser

Next by Date:

[Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Herbert Xu

Previous by Thread:

[Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Keir Fraser

Next by Thread:

[Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Herbert Xu

Indexes:

[Date] [Thread] [Top] [All Lists]