WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [XENBUS] Avoid direct use of xen_start_i

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Xen-changelog] [XENBUS] Avoid direct use of xen_start_info.
From: Steven Smith <sos22-xen@xxxxxxxxxxxxx>
Date: Tue, 15 Aug 2006 10:04:40 +0100
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, sos22@xxxxxxxxxxxxx, Steven Smith <ssmith@xxxxxxxxxxxxx>
Delivery-date: Tue, 15 Aug 2006 02:05:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1155584268.30510.104.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1GChyz-0004xc-M8@xxxxxxxxxxxxxxxxxxxxx> <1155584268.30510.104.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> This is great, because on PowerPC we're looking to drop struct
> start_info entirely. However, I notice there are still a fair number of
> 'xen_start_info' references in drivers/xen. Are there more of these
> patches coming Steven, or since HVM guests don't use those drivers
> you're not pursuing them?
I wasn't planning on doing so since, as you say, none of the others
are relevant to HVM guests.

> > @@ -1014,8 +1017,13 @@ static int __init xenbus_probe_init(void
> >             if (xsd_port_intf)
> >                     xsd_port_intf->read_proc = xsd_port_read;
> >  #endif
> > -   } else
> > +   } else {
> >             xenstored_ready = 1;
> > +           xen_store_evtchn = xen_start_info->store_evtchn;
> > +           xen_store_mfn = xen_start_info->store_mfn;
> > +   }
> > +
> > +   xen_store_interface = mfn_to_virt(xen_store_mfn);
> >  
> >     /* Initialize the interface to xenstore. */
> >     err = xs_init();
> Could we abstract this part more please? I think calling into an
> arch-provided xen_get_store_mfn() function would be good. (And of course
> the same for store_evtchn and the console_* equivalents.)
This'd probably reduce the number of #ifdef's in the PV-on-HVM patches
as well, so I'd be happy to see it.

Steven.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>