WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][XEN]xm dump command add on

On Tue, 2006-08-15 at 00:58 +0100, John Levon wrote:
> On Tue, Aug 15, 2006 at 08:49:57AM +0900, Ken Hironaka wrote:
> 
> > > Better as "Domain core dump requested for domain %s (%d)" ?
> > > 
> > I must note, this section is in C code and not Python, as it is part
of
> > xc_dumpcore() in libxc. I understand that it is better to log the
error
> > as soon as possible, but logging takes place at the Python layer
above.
> 
> Not sure why that's relevant? I was merely asking for better text for
> the message.

Oh ok, sorry I was just a little confused. thank you.
> 
> > > > +    if not live:
> > > > +        print "pausing domain:%s ..." % str(dom)
> > > > +        server.xend.domain.pause(dom)
> > > 
> > > Is it really worth mentioning the pause? It doesn't take any
amount of
> > > time, surely.
> > Yes, I do think that is is necessary to mention a pause. There are
times
> > when the user will send an Interrupt with say, CTRL+C at the middle
of
> > dumping. Of course, xm dump will terminate, but the domU will
continue
> 
> Perhaps that's a bug - it should clean up on a control-C by unpausing
> the domain, if appropriate.

Ok, I will take your advice into consideration. It's a simple keyboard
Interrupt exception catch so, it won't be a problem fixing it. I will
add these fixes and reemit the patch.

Thank you for your input.

best regards,
Ken



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel