xen-devel

[Top] [All Lists]

[PATCH] Re: [Xen-devel] omission in x86-64's entry-xen.S ?

from [Jan Beulich]

[Permanent Link][Original]

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>,<jun.nakajima@xxxxxxxxx>
Subject:	[PATCH] Re: [Xen-devel] omission in x86-64's entry-xen.S ?
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Mon, 14 Aug 2006 14:56:59 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 14 Aug 2006 05:57:18 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C0FDFE0A.9F2%Keir.Fraser@xxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<44D85AA3.76E4.0078.0@xxxxxxxxxx> <C0FDFE0A.9F2%Keir.Fraser@xxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>> following sysret_signal there is a 'cli' left, but the hypervisor
doesn't even
>> emulate this anymore as equivalent of
>> clearing evtchn_upcall_mask - I'm fairly certain XEN_BLOCK_EVENTS()
is meant
>> here, otherwise a comment should explain
>> why this needs to keep the native instruction.
>
>Any stupidities you see in x86/64 entry-xen.S almost certainly really
are
>bugs. Please send a patch!

Here we (finally) go:

This fixes
- one instance of using XEN_BLOCK_EVENTS where XEN_UNBLOCK_EVENTS was
  meant
- four instances of left-over cli-s that should have been replaced
with
  XEN_BLOCK_EVENTS
- one instance of slightly wrong placement (without resulting in ill
behavior, but
  needlessly making the diff to native more complex)

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

xenlinux-x86_64-event-blocking.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] omission in x86-64's entry-xen.S ?, Jan Beulich Re: [Xen-devel] omission in x86-64's entry-xen.S ?, Keir Fraser [PATCH] Re: [Xen-devel] omission in x86-64's entry-xen.S ?, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] [PATCH][XEN]xm dump command add on, Keir Fraser
Next by Date:	[Xen-devel] [PATCH] linux: fix improper attribute (section) of clean_loopback, Jan Beulich
Previous by Thread:	Re: [Xen-devel] omission in x86-64's entry-xen.S ?, Keir Fraser
Next by Thread:	[Xen-devel] Windows 2003 Server does not see all 5 GB of RAM, Zheng, Jeff
Indexes:	[Date] [Thread] [Top] [All Lists]