 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][XEN] fix missing header and gcc warning
| To: | Markus Armbruster <armbru@xxxxxxxxxx>, Jimi Xenidis <jimix@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][XEN] fix missing header and gcc warning |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Mon, 14 Aug 2006 09:37:07 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Mon, 14 Aug 2006 01:37:49 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <87ac67akoc.fsf@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Aca/fNNjEaehwytwEdu/pgAKle7CWA== |
| Thread-topic: | [Xen-devel] [PATCH][XEN] fix missing header and gcc warning |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 14/8/06 7:36 am, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote: >> - memcpy(dp + op->dest.offset, sp + op->source.offset, op->len); >> + memcpy((void *)((ulong)dp + op->dest.offset), >> + (void *)((ulong)sp + op->source.offset), >> + op->len); > > I find this needlessly ugly. Why not just declare sp and dp char *? That's what I checked in. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH][XEN]xm dump command add on, Ken Hironaka |
|---|---|
| Next by Date: | RE: [Xen-devel] Xen0 hangs after VMX create, Li, Xin B |
| Previous by Thread: | Re: [Xen-devel] [PATCH][XEN] fix missing header and gcc warning, Markus Armbruster |
| Next by Thread: | [Xen-devel] Xen0 hangs after VMX create, Zheng, Jeff |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
