Re: [Xen-devel] [0/9] [NET]: Add TSO support for dom0=>domU

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Aug 04, 2006 at 12:06:51PM +0100, Emmanuel Ackaouy wrote:
> 
> vif = [ '', 'bridge=xenbr0' ]

Interesting.  I believe this is due to a missing netif_rx_schedule
when netfront's interface is brought up.  Please let me know if this
patch fixes it or not.

[NET] front: Check for received packets in network_open0

Because the backend brings up the interface long before the frontend
has booted up, it is possible that by the time we get here we already
have packets queued up for processing.

If we don't process them here, we may delay them more than what is
necessary.  Worse yet, it is possible to miss the notification
interrupt from the backend in such a way that we never get another
one until we bring the interface down and up.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff -r 3efef49b7b49 linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c
--- a/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Fri Aug 04 
17:03:43 2006 +1000
+++ b/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c      Sat Aug 05 
00:21:48 2006 +1000
@@ -497,6 +497,9 @@ static int network_open(struct net_devic
        network_alloc_rx_buffers(dev);
        np->rx.sring->rsp_event = np->rx.rsp_cons + 1;
 
+       if (RING_HAS_UNCONSUMED_RESPONSES(&np->rx))
+               netif_rx_schedule(dev);
+
        netif_start_queue(dev);
 
        return 0;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel