WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/2] Virtual frame buffer: frontend

To: Laurent Vivier <Laurent.Vivier@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2] Virtual frame buffer: frontend
From: Markus Armbruster <armbru@xxxxxxxxxx>
Date: Fri, 04 Aug 2006 09:54:51 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 04 Aug 2006 00:55:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44CA16BA.5050702@xxxxxxxx> (Laurent Vivier's message of "Fri, 28 Jul 2006 15:52:58 +0200")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <87ac80ghox.fsf@xxxxxxxxxxxxxxxxx> <8764ioghnn.fsf@xxxxxxxxxxxxxxxxx> <44CA16BA.5050702@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
Laurent Vivier <Laurent.Vivier@xxxxxxxx> writes:

> Hi,
>
> my domain hangs when I load xenfb module.
>
> The sequence is:
> dom0# sdlfb <id>
> ...
> domU# modprobe fbcon
> domU# modprobe xenkbd
> domU# modprobe xenfb
> ... HANGS HERE ....
>
> I found that it hangs in xenfb_event_handler() because info->page->in_prod and
> info->page->in_cons are not initialized correctly.

You're right.  I missed that error, then had the bad luck that it
happened to work for me every time.

> I propose following correction:
>
> Index: xen-3.0-testing.hg/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> ===================================================================
> --- xen-3.0-testing.hg.orig/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> 2006-07-28 12:58:47.000000000 +0200
> +++ xen-3.0-testing.hg/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> 2006-07-28 15:28:23.000000000 +0200
> @@ -414,6 +414,8 @@
>         info->page->depth = 32;
>         info->page->line_length = (info->page->depth / 8) * info->page->width;
>         info->page->mem_length = xenfb_mem_len;
> +       info->page->in_cons = info->page->in_prod = 0;
> +       info->page->out_cons = info->page->out_prod = 0;

Works for me.

>         ret = bind_evtchn_to_irqhandler(info->evtchn, xenfb_event_handler,
>                                         0, "xenfb", info);
>
>
> Regards,
> Laurent

Sorry for the slow reply, I was sick.

Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>