WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific cod

To: "Alex Williamson" <alex.williamson@xxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific code for new qemu.
From: "Christian Limpach" <christian.limpach@xxxxxxxxx>
Date: Wed, 26 Jul 2006 21:14:28 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Jul 2006 13:14:53 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=IWKILWhQl07ygC2LyHkDJAf+47xJ/KAUVSGWtyiBqq1c2vUlBhlNrsDZP0IcmVfupaZC6GsE9nVVFCHGPQccp8H0rS2P7jA7sFc6GPHTjBbZjrn/LFvd8XrFMZV/MYa/c/5XVpiwAZiurZN1FPiQZnBGlpDGe8nByP31+y2dBIk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1153934403.5403.12.camel@lappy>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CA502B3E9EE27B4490C87C12E3C7C8510B25BF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <2FC6B0A5FE3BFEtakebe_akio@xxxxxxxxxxxxxx> <3d8eece20607260541x1acce9b3k974f7207d8ed3eeb@xxxxxxxxxxxxxx> <1153934403.5403.12.camel@lappy>
Reply-to: Christian.Limpach@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 7/26/06, Alex Williamson <alex.williamson@xxxxxx> wrote:
On Wed, 2006-07-26 at 13:41 +0100, Christian Limpach wrote:
> On 7/26/06, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx> wrote:
> > Hi, Xiantao
> >
> > Is the following testandset redefine?
> >
> > diff -r bbabdebc54ad tools/ioemu/exec-all.h
> > --- a/tools/ioemu/exec-all.h    Wed Jul 19 21:13:36 2006 +0100
> > +++ b/tools/ioemu/exec-all.h    Tue Jul 25 09:30:05 2006 +0800
> > @@ -391,6 +391,15 @@ static inline int testandset (int *p)
> >  }
> >  #endif
> >
> > +#ifdef __ia64__
> > +#include "ia64_intrinsic.h"
> > +static inline int testandset (int *p)
>
> I've merged it with the existing __ia64 case.

Hi Christian,

   Looks like we still ended up with both copies.  Can you please apply
the patch below.  Thanks,

Oops yeah, looks like I forgot to remove the added copy after changing
the other one to match.

    christian


Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
---

diff -r 21918b22746e tools/ioemu/exec-all.h
--- a/tools/ioemu/exec-all.h    Wed Jul 26 10:49:32 2006 -0600
+++ b/tools/ioemu/exec-all.h    Wed Jul 26 11:16:28 2006 -0600
@@ -391,15 +391,6 @@ static inline int testandset (int *p)
 }
 #endif

-#ifdef __ia64__
-#include "ia64_intrinsic.h"
-static inline int testandset (int *p)
-{
-    uint32_t o = 0, n = 1;
-    return (int)cmpxchg_acq(p, o, n);
-}
-#endif
-
 #ifdef __s390__
 static inline int testandset (int *p)
 {




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel