| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarc
|
To: |
Arjan van de Ven <arjan@xxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Andi Kleen <ak@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Zachary Amsden <zach@xxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarch |
|
From: |
"Randy Dunlap" <rdunlap@xxxxxxxxxxxx> |
|
Date: |
Tue, 18 Jul 2006 06:07:18 -0700 |
|
Delivery-date: |
Thu, 20 Jul 2006 05:19:21 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
> On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
> > plain text document attachment (i386-setup)
> > Implement the start-of-day subarchitecture setup hooks for booting on
> > Xen. Add subarch macros for determining loader type and initrd
> > location.
>
> > diff -r a5848bce3730 arch/i386/kernel/setup.c
> > --- a/arch/i386/kernel/setup.c Thu Jun 22 16:02:54 2006 -0400
> > +++ b/arch/i386/kernel/setup.c Thu Jun 22 20:20:31 2006 -0400
> > @@ -458,6 +458,7 @@ static void __init print_memory_map(char
> > }
> > }
> >
> > +#ifndef HAVE_ARCH_E820_SANITIZE
> > /*
> > * Sanitize the BIOS e820 map.
> > *
> > @@ -677,6 +678,7 @@ int __init copy_e820_map(struct e820entr
> > } while (biosmap++,--nr_map);
> > return 0;
> > }
> > +#endif
> >
> Hi,
>
> what is this for? Isn't this 1) undocumented and 2) unclear and 3)
> ugly ? (I'm pretty sure the HAVE_ARCH_* stuff is highly deprecated for
> new things nowadays)
I've read that Linus doesn't like it (putting it mildly),
but deprecated?? Yes, there are better/other ways.
---
~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread> |
- [Xen-devel] Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarch,
Randy Dunlap <=
|
|
|
| |
|
Home