 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Xen scheduling bug?
| To: | "Stephen C. Tweedie" <sct@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Xen scheduling bug? |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Sat, 15 Jul 2006 17:25:04 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Sat, 15 Jul 2006 09:32:33 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1152977884.5133.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <1152977884.5133.5.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 15 Jul 2006, at 16:38, Stephen C. Tweedie wrote: Note the marked lines --- Xen is turning irqs _off_ at this point, when non-Xen is turning them on. I just noticed it when merging the irqtracing code. Bug? Definitely -- we shouldn't enter schedule() with interrupts disabled. I think entry-xen.S needs an audit for this kind of thing. Just a few lines above this bug we XEN_UNBLOCK_EVENTS() where we shouldn't (race to userspace against schedule/signals), and that's probably unnecessary since we will return to userspace via the IRET hypercall which will safely atomically reenable interrupts anyway. I haven't currently time to patch and test these problems -- if you can do it quicker and post a patch that would be very handy. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-users] usb-patch, Nivedita Singhvi |
|---|---|
| Next by Date: | Re: [Xen-devel] Using LinuxBIOS as virtual firmware, Yinghai Lu |
| Previous by Thread: | [Xen-devel] Xen scheduling bug?, Stephen C. Tweedie |
| Next by Thread: | RE: [Xen-devel] Xen scheduling bug?, Nakajima, Jun |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
