[Xen-devel] Broken x86_64 make install again (was Re: merge with xen-unstable.hg)

[Sean Dague <japh@xxxxxxxxxx>]

This patch (about a month ago), broke x86_64 "make install" again due to:

On Thu, Jun 01, 2006 at 12:08:33PM +0000, Xen patchbot-unstable wrote:
<snip>
> # HG changeset patch
> # User awilliam@xxxxxxxxxxx
> # Node ID acabf4bdec4fb4cca056f4c80deaab32e9f1b767
> # Parent  3be4c828873766eb580541b2f977f01a72431991
> # Parent  0ec4b9dfd5b441fef5422c98077b30a7f29f10d9
<snip>

> diff -r 3be4c8288737 -r acabf4bdec4f
> linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/dma-mapping.h
> --- a/linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/dma-mapping.h        
> Wed
> May 31 11:30:07 2006 -0600
> +++ b/linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/dma-mapping.h        
> Wed
> May 31 13:05:21 2006 -0600
> @@ -128,8 +128,6 @@ dma_get_cache_alignment(void)
>        * maximum possible, to be safe */
>       return (1 << INTERNODE_CACHE_SHIFT);
>  }
> -#else
> -extern int dma_get_cache_alignment(void);
>  #endif
>  
>  #define dma_is_consistent(d) (1)

The result is that a make install has the following errors building the b44
module again.

...
if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map -b 
/ -r 2.6.16.13-xen; fi                                                          
WARNING: //lib/modules/2.6.16.13-xen/kernel/drivers/net/b44.ko needs unknown
symbol dma_get_cache_alignment                                                  
   
make[3]: *** [_modinst_post] Error 1
make[3]: Leaving directory `/home/sdague/xen-unstable/linux-2.6.16.13-xen'
make[2]: *** [build] Error 2
make[2]: Leaving directory `/home/sdague/xen-unstable'
make[1]: *** [linux-2.6-xen-install] Error 2
make[1]: Leaving directory `/home/sdague/xen-unstable'
make: *** [install-kernels] Error 1

Please reverse the patch above to return x86_64 to a working for make
install.

        -Sean

-- 
Sean Dague
IBM Linux Technology Center                     email: japh@xxxxxxxxxx
Open Hypervisor Team                           alt: sldague@xxxxxxxxxx

pgpGIDnjoQ1g4.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel