Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)

["KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>]

Hi Keir,

>>>>> On Tue, 4 Jul 2006 08:06:57 +0100
>>>>> Keir.Fraser@xxxxxxxxxxxx(Keir Fraser)  said:
> 
> 
> On 4 Jul 2006, at 06:37, KUWAMURA Shin'ya wrote:
> 
> > This patch removes the magic number "31" for readability. The number
> > "31" means the idle domain ID.
> 
> Where does the magic number '31' come from in the first place? That's 
> not the number Xen uses. It could conflict with the domain id of a 
> non-idle domain.

"31" comes from xenmon.py and xenbaked.h.
xenmon.py:38:
  NDOMAINS = 32

xenbaked.h:42
  #define NDOMAINS 32

Notice that 31 is NDOMAINS-1.

Therefore, xenmon supports only up to 32 domains.

Thanks,
-- 
  KUWAMURA Shin'ya

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel