[Xen-devel] Re: [RFC][PATCH] synchronize console on BUG()

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Jun 29, 2006, at 6:01 AM, Horms wrote:

> In article <E1Fvahf-0001xr-ME@xxxxxxxxxxxxxxxxxxxxx> you wrote:
> > The following patch syncs (and unsync) the console while we are in  
> > the
> > BUG() macro.
> >
> > The separate externs (which I dislike) for these console calls are
> > there because including <xen/console.h> breaks all sorts of files,  
> > any
> > suggestions on how to solve this is welcome.
> Is this breakage because <xen/console.h> doesn't #include all the
> headers for the stuff it uses itself? If so could someone coment on
> if that is intentional, or if it is something that (generally) wants
> fixing.
Methinks it includes to much, for some of the more finikier files.
My suggestion is that we should have a minimal header that contains  
prototypes for console_sync(), panic(), ASSERT, BUG, and whatever  
else there is (perhaps remove the redundant ones if there are any).
thoughts?
-JX



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel