Re: [Xen-devel] [0/5] [NET]: Add TSO support

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Hi Keir:

OK here they are again with your comments addressed.

On Tue, Jun 27, 2006 at 02:27:20PM +0100, Keir Fraser wrote:
> 
> Comments on the patches:
>  1. Can you make two separate patches in the patches/ directory -- one 
> for the stuff already accepted upstream and a separate one for the 
> stuff that is not yet accepted. Prefix the patch files with numbers to 
> make sure they get applied in the right order.

This is no longer necessary as the header verification patch has now
been merged.

>  2. As well as the patches you provide, some generic Linux files are 
> modified in the sparse tree because we already modify them there. Can 
> you please also place a copy of your changes inside your patches/ 
> files. This will make it easier for us to forward port to 2.6.18 as we 
> can see which changes in the sparse tree actually correspond to the 
> generic GSO changes.

Done.

>  3. Can you give brief documentation, or even just send a an email 
> explaining, how you change the interdomain protocol to add GSO?

I've included it in the TSO backend patch's description.

>  4. The change to make_tx_response() prototype in netback you could 
> send us as a separate patch. It would make the real GSO changes to 
> netback smaller and clearer.

Done.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel