RE: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests information to /proc/xen/vbd

["Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx>]

Hi,

> I looked at the code, and it seems "oo" stands of "out of", which  
> indicates how much we were out of request (Xen supports up to 64 
> requests in queue)

Thanks.
It may be correct.

>Few minor comments:
>- The variable dom_io_info_wq is unused, should be removed.
>- printk("%s: out of memory\n", __FUNCTION__) should be used with 
>KERN_ERR

Thanks.
I want to review around these codes.


>I have one question: in your below output:
>
>> Domain 4 - oo        0  rd    18699  wr        2
>>  xvd 4  8:21 - oo        0  rd    18699  wr        2
>
>I notice that you output the domid with xvd (4), but in the above line, we 
>already had that information (Domain 4).
> So why you need to show the domid again?

VBD processes in domain0 runs as xvd threads.
These threads names "xvd [Domain name] [Major Number]:[Minor Number]".
So, I show same name inelligibly.
In addition, I think that total Information for each domain is added optionally.
Therefore, its informatin is needed in such time.


Thanks,
Satoshi UCHIDA



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel