WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] load 64-bit files with 32-bit tools

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] load 64-bit files with 32-bit tools
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 20 Jun 2006 08:30:17 +0100
Cc: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 20 Jun 2006 00:36:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44974DE6.3070701@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FsUWR-0001Ln-Vq@xxxxxxxxxxxxxxxxxxxxx> <44974DE6.3070701@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 20 Jun 2006, at 02:22, Anthony Liguori wrote:

I believe that on x86-64 uint64_t is defined to be unsigned long.

I think the proper (albeit ugly) thing to do here is use PRIu64.

Or change the _p() macro to cast to void* via long. Then we continue to print in the same format we always have for 32-bit x86 guests. Makes the patch a bunch smaller too.

My main concern with this patch is whether, by using a wider type, it breaks any of the address-wrapping validation checks we added. On first glance it looks okay though.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>