WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xc_evtchn_*() interfaces

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xc_evtchn_*() interfaces
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Wed, 14 Jun 2006 20:44:45 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 14 Jun 2006 12:45:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <904d81044bc745f5b2d1ac4ea24a8319@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060614174721.GA9810@xxxxxxxxxxxxxxxxxxxx> <904d81044bc745f5b2d1ac4ea24a8319@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Jun 14, 2006 at 08:06:18PM +0100, Keir Fraser wrote:

> >No longer open the device as non-blocking: all reads immediately follow
> >a select() on the device indicating it's ready to read.
> 
> Why change this?

Because not all users specified O_NONBLOCK, so to keep the exact same
code would mean complicating the API a little bit. As there is no extant
code that actually takes advantage of O_NONBLOCK, it's pointless having
the extra code (note that xenstore would actually die if it ever got
EAGAIN...)

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel