 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] shared_info setup
| To: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] shared_info setup |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 2 Jun 2006 15:45:38 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 02 Jun 2006 07:46:03 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <448064C0.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <448064C0.76E4.0078.0@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 2 Jun 2006, at 15:18, Jan Beulich wrote: Isn't the comparison in the two places where HYPERVISOR_shared_info gets set up wrong in comparing a machine (=physical) address to a page count? I.e., shouldn't either it or nr_pages be shifted by PAGE_SHIFT? Jan I think so. But I think actually the place that sets up without using fixmap could probably be got rid of -- although in that case there is no need to use fixmap, since we have the fixmap entry and the code to fill it in, we may as well do that in all cases. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] shared_info setup, Jan Beulich |
|---|---|
| Next by Date: | [Xen-devel] privileged op emulation, Altobelli, David |
| Previous by Thread: | [Xen-devel] shared_info setup, Jan Beulich |
| Next by Thread: | [Xen-devel] privileged op emulation, Altobelli, David |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
