WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 02 Jun 2006 12:53:55 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Jun 2006 03:53:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <5324398cd809a2cde429589727c53ee5@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4480296D.76E4.0078.0@xxxxxxxxxx> <5324398cd809a2cde429589727c53ee5@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 02.06.06 12:19 >>>
>
>On 2 Jun 2006, at 11:05, Jan Beulich wrote:
>
>> Add backing support for HDIO_GETGEO ioctl to blkfront.
>>
>> Inspired by an earlier patch from Charles Coffing.
>
>Does this have any effect? It looks to me as though HDIO_GETGEO is 
>handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other 
>blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just 
>remove that case from our ioctl switch statement and define a 'getgeo' 
>function hook?

But that is exactly what the patch does. It instead adds a getgeo function to 
vbd, which is what several other drivers
also have, and which is what backs blkdev_ioctl()'s handling of HDIO_GETGEO.

>Given that this patch can't have any effect, what drove you guys to 
>implement it? :-)

We saw GrUB failing when used inside a domU.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel