WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86-64 linux: unmap temporary mappings establish

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86-64 linux: unmap temporary mappings established for setup of 1:1 mappings
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 02 Jun 2006 09:29:47 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Jun 2006 00:29:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <368ae6e00389bbd4d2b4fdd55ddc5411@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <447DB394.76E4.0078.0@xxxxxxxxxx> <368ae6e00389bbd4d2b4fdd55ddc5411@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 01.06.06 20:21 >>>
>
>On 31 May 2006, at 14:17, Jan Beulich wrote:
>
>> The temporary mappings needed to set up the 1:1 mappings must be torn 
>> down after use; otherwise they may trigger the
>> WARN_ON() in vmap_pte_range() (namely if the chunk allocated to hold 
>> kernel and initial page tables gets close to or
>> exceeds 128Mb, or if a sufficiently high mem= argument causes the 
>> static allocations to grow beyond 128Mb, which in
>> either case means these mappings extend into the modules area).
>
>I've applied this to -unstable, but in this patch I only see code to 
>destroy the extended init mappings. What happens if you have a really 
>big initrd (for example)? That will push the initial pagetables up into 
>the modules area -- is that handled correctly now or is more fixup 
>required?

The initrd mappings, as I read it, get destroyed in setup_arch(). The thing 
that also came to my mind were the
Xen-created page tables, which might need taking care of. The main issue here 
will be to precisely determine the
boundary of where to start destruction - does Xen make any guarantees regarding 
the ordering of things within the
initial allocation?

>Also your patch didn't apply to 3.0-testing. You'll need to supply a 
>version specifically for -testing if you want it applied there.

Yes, that patch would look different. As we have our own patch anyway, I don't 
think we insist on this being applied to
3.0-testing, but in case you want it I'm attaching the patch we have (one of 
its hunks applies with fuzz 1 only, but I
think that should be okay).

Jan

Attachment: xen-x86_64-unmap-early.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel