WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] RE: [Xen-users] Xen in a 32 way system

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [Xen-users] Xen in a 32 way system
From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Date: Thu, 1 Jun 2006 20:22:10 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>, Pablo Montesinos <pablomontesinos@xxxxxxxxx>, Ryan Harper <ryanh@xxxxxxxxxx>, Uros Trebec <uros.trebec@xxxxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 01 Jun 2006 11:23:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <505965ad2086fb69089eacd383acdbd8@xxxxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcaFp7y/V3l8IaypRKK4hKmvTO0lWAAADdHQ
Thread-topic: [Xen-devel] RE: [Xen-users] Xen in a 32 way system
> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
> Sent: 01 June 2006 19:09
> To: Petersson, Mats
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Puthiyaparambil, Aravindh; 
> Uros Trebec; Ryan Harper; xen-users@xxxxxxxxxxxxxxxxxxx; 
> Pablo Montesinos
> Subject: Re: [Xen-devel] RE: [Xen-users] Xen in a 32 way system
> 
> 
> On 1 Jun 2006, at 18:59, Petersson, Mats wrote:
> 
> > Isn't it a bug that we don't check for -EINVAL in the line here:
> >         for (i = 0; i < NR_CPUS; i++) {
> >                 rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
> >                 if (rc == -ENOENT)
> >                         break;
> >                 cpu_set(i, cpu_possible_map);
> >         }
> >
> > If NR_CPUS in Linux is bigger than 32, then rc = -EINVAL, 
> not -ENOENT 
> > when it returns from the vcpu_op, because the first check 
> is to see if 
> > vcpuid is >=32...
> >
> > Checking if (rc < 0) would be better, I should think...
> 
> Yes, the current code is rather mad. I'll fix it.

Of course, if NR_CPUS is 32, it shouldn't matter... 

Pablo, can you check the CONFIG_NR_CPUS in your .config for your
linux-2.6.16.13-xen? As in my system, NR_CPUS = 32.. 

--
Mats
> 
>   -- Keir
> 
> 
> 


_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users