| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] cpuid feature bits masking for HVM guests
|
To: |
"Kamble, Nitin A" <nitin.a.kamble@xxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] cpuid feature bits masking for HVM guests |
|
From: |
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|
Date: |
Fri, 19 May 2006 16:59:51 +0100 |
|
Cc: |
"Mallick, Asit K" <asit.k.mallick@xxxxxxxxx>, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Yu, Wilfred" <wilfred.yu@xxxxxxxxx> |
|
Delivery-date: |
Fri, 19 May 2006 09:00:12 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<E305A4AFB7947540BC487567B5449BA80A91C280@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<E305A4AFB7947540BC487567B5449BA80A91C280@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 18 May 2006, at 20:11, Kamble, Nitin A wrote:
Hi Keir, Ian,
Attached patch implements masking of some of the cupid bits from
the guest. It also cleans up the previous cupid handling code.
Please apply and/or comment.
I think the choice of macros is a bit bizarre. Do you really need to
have a set of CPU_LEAF_n=n macros? How does that help? Also the
FOO_RESERVED_first_last=bitmask I don't really find helpful -- most of
us can read a bitmask!
Those lines of patch could more usefully be used defining macros, or
simply adding a multi-line comment or two, which describe what the bits
you are masking actually *do*. What features are you masking, and why?
-- Keir
Signed-Off-By: Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
Signed-Off-By: Jun Nakajima <jun.nakajima@xxxxxxxxx>
Thanks & Regards,
Nitin
-----------------------------------------------------------------------
------------
Open Source Technology Center, Intel Corp
<cpuid_9.patch>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home