 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6
| To: | "Pascal Bouchareine" <pascal@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6 |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Tue, 16 May 2006 09:18:39 +0200 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Tue, 16 May 2006 00:18:22 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20060515181525.GA2110@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20060515181525.GA2110@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch: - Why do you need to add BLKGETSIZE and BLKGETSIZE64? block/ioctl.c is already taking care of those, they should never arrive at the driver. - The calculation of the cylinder value seems odd to me. Why don't you use sector_div() here? - There is an apparently unused variable 'dpart' left in blkif_getgeo(). Jan >>> Pascal Bouchareine <pascal@xxxxxxxxx> 15.05.06 20:15 >>> Hi, Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront. An attempt to merge in the following sent previously by Ian Pratt : http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html Taking into account the block_device_operations for get_geom. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] [PATCH] make HVM PIC emulation code SMP-safe, Dong, Eddie |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races, Chris Wright |
| Previous by Thread: | [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6, Pascal Bouchareine |
| Next by Thread: | Re: [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6, Pascal Bouchareine |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
