WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Calculate correct instruction length for data-fa

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Calculate correct instruction length for data-fault VM exits on VT-x systems
From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Date: Fri, 28 Apr 2006 11:19:57 +0200
Cc: Khoa Huynh <khoa@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 Apr 2006 02:20:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZqpEbCLw4JDdREQUKCRMqD9MoakgAAJ9/g
Thread-topic: [Xen-devel] [PATCH] Calculate correct instruction length for data-fault VM exits on VT-x systems
 

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Keir Fraser
> Sent: 28 April 2006 10:15
> To: Petersson, Mats
> Cc: Khoa Huynh; xen-devel
> Subject: Re: [Xen-devel] [PATCH] Calculate correct 
> instruction length for data-fault VM exits on VT-x systems
> 
> 
> On 28 Apr 2006, at 10:02, Petersson, Mats wrote:
> 
> > I'll look at your previous suggestion of merging the MMIO emulation 
> > into x86_emulate later on today. We probably do need to sum up the 
> > length and pass it back to the caller - as that code 
> doesn't know how 
> > to update the correct field of the different processor 
> architectures 
> > (vmcb vs. vmcs vs. stack-frame for Para-virtual machine). But it 
> > shouldn't be particularly hard to achieve this.
> 
> The emulator uses and updates the eip field of the passed-in 
> regs structure. We may want to change this interface in 
> future by having the caller explicitly pass in a buffer 
> containing the instruction, and the number of valid bytes in 
> the buffer.  Or add a 'fetch_insn_byte' 
> callback hook to the emulator interface.

I think passing a buffer is the best choice here. And I suppose we can
always stuff vmc[bs]->rip into regs->eip and pull it back out again when
we get back - using a wrapper function may be the easiest way to achieve
this (at least short term). 

We will of course also need to get the communication with QEMU done in
some way.

I haven't spent any time looking at it so far... 

--
Mats
> 
>   -- Keir
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>