WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_reservation()
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 28 Apr 2006 16:23:32 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 28 Apr 2006 00:23:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9a6ef76c6b1cedc2327ac6255a5c2661@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060428063238.GA23653%yamahata@xxxxxxxxxxxxx> <9a6ef76c6b1cedc2327ac6255a5c2661@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Apr 28, 2006 at 07:59:04AM +0100, Keir Fraser wrote:

> x86 phys_to_machine_ampping_valid() includes a check of the  
> autotranslate feature flag. It always returns 1 if that flag is set.

Yes. So when autotranslate feature flag is set,
BUG_ON(phys_to_machine_mapping_valid(pfn)) becomes BUG_ON(1)
which results in kernel panic.
This means that the balloon driver can't be used with autotranslate
feature flag set.
Is this really your intention?

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel