Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/i

To:	"Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64
From:	"Christian Limpach" <christian.limpach@xxxxxxxxx>
Date:	Tue, 25 Apr 2006 11:00:52 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 25 Apr 2006 03:01:14 -0700
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hGdaDdw3KnbHbXYXFdy9unqaCtEnNM8twRUL/EDvjGIqMDjqnnyR1vchpmodVQIRpeIpHwEa8lWr4O2eobOHHPr+lRi2cRRWDlm1g4Ru6EmElSaRq2FcUAVCvO2xTY9df93LOEhrTb1f3NbIDAVEm6b1wr7L2S9q/njjso8Y4d4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20060425043052.GF26453%yamahata@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20060425043052.GF26453%yamahata@xxxxxxxxxxxxx>
Reply-to:	Christian.Limpach@xxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 4/25/06, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:


xenLinux/ia64 with dom0 vp model uses
linux-2.6-xen-sparse/arch/i386/kernel/pci-dma-xen.c.
But it has its own dma_map_page(), dma_declare_coheremnt_memory() and their
families. So those in pci-dma-xen.c are unnecessary. #ifdef out them.


Does this work?  If you have your own dma_declare_coherent_memory(),
don't you then need to #define ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY so
that you don't get the default implementations in linux/dma-mapping.h?

I also don't like the ifdef on dma_map_page since it requires you to
#define it to something else to override it instead of implementing
it.

I prefer to have #if defined(__i386__) || defined(__x86_64__) (maybe

with a comment stating !defined(__ia64__)) which will make it clearwhy these are ifdef'ed out.


I think this approach is ok for now since we haven't decided whether
to merge this file back into i386' pci-dma or move it to
drivers/xen/core.

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64