[Xen-devel] question (bug?) in xeno-linux code

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] question (bug?) in xeno-linux code
From:	"Runting Shi" <rshi@xxxxxxx>
Date:	Tue, 18 Apr 2006 16:41:25 -0400 (EDT)
Delivery-date:	Thu, 20 Apr 2006 03:12:18 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
Importance:	Normal
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	SquirrelMail/1.5.1 [CVS]

Hey, in xeno-linux, arch/i386/mm/pgtable-xen.c (line 363),

why are we doing set_pgd(&pgd[USER_PTRS_PER_PGD], __pgd(1 + __pa(pmd)));

shouldn't it be set_pgd(&pgd[USER_PTRS_PER_PGD + i], __pgd(1 + __pa(pmd))) 
or something?

I am just wondering why the for loop is there at all....


Thanks,

Elaine


for (i = USER_PTRS_PER_PGD; i < PTRS_PER_PGD; i++) {
                        pmd_t *pmd = kmem_cache_alloc(pmd_cache, GFP_KERNEL);
                        if (!pmd)
                                goto out_oom;
                        set_pgd(&pgd[USER_PTRS_PER_PGD], __pgd(1 + __pa(pmd)));
                }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] question (bug?) in xeno-linux code