[Fwd: Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI on shutdown.]

[Harry Butterworth <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

Ewan,

    Keir seems to think this patch is OK.  I tested it on an
Intellistation A Pro for x86_64 and it works for me.  I think it is low
risk because it's executed at the end of the shutdown process.  Please
apply.

http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00223.html

--- Begin Message ---

To:	Harry Butterworth <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI on shutdown.
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Fri, 7 Apr 2006 08:27:50 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Envelope-to:	harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to:	<1144358555.4775.10.camel@localhost>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<1144348570.7725.9.camel@xxxxxxxxxxxxxxxxxxxxx> <20060406184602.GB20687@xxxxxxxxxxxxxxxxxxx> <1144349930.21520.4.camel@xxxxxxxxxxxxxxxxxxxxx> <20060406190647.GC20687@xxxxxxxxxxxxxxxxxxx> <1144358555.4775.10.camel@localhost>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 6 Apr 2006, at 22:22, Harry Butterworth wrote:

It might be better to install the hypervisor call in pm_power_off and
let it get replaced by the acpi_power_off call if ACPI is detected.
That would seem to fit in better with the way the x86 arch handles
multiple power off strategies.

I haven't looked to see how the other architectures do power off yet.

Was hoping for some comment about whether to do power off in xen or in
domU and whether the hypervisor needed notification.

I think your patch looked okay for now, actually. Alternatively our machine_restart() could be moved into arch-specific code files. Doing the power off in dom0 is fine -- as you say, Xen doesn't do anyhting special before shutdown.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

--- End Message ---

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel