Re: [Xen-devel] [PATCH][XM-TEST] correct inconsistent reporting in xm-test

[Dan Smith <danms@xxxxxxxxxx>]

>  submit_report() {
> -
>      reportfile=$1
> -
> -    ./lib/XmTestReport/Report.py $reportfile
> +    if [ "$GROUPENTERED" = "default" ];then
> +       ./lib/XmTestReport/Report.py $reportfile
> +    else
> +       echo "No report submitted for $REPORT, requires a default group run."
> +    fi
>  }

Why change the semantics of submit_report() from "submit a report" to
"maybe submit a report" ??  The script already has a method for
disabling the report submission based on certain criteria.  You should
use that to achieve the desired behavior.
 
>  make_environment_report() {
>      os=$1
>      prog=$2
> +    rm -f $REPORT"*" > /dev/null 2>&1
>      if ! ./lib/XmTestReport/OSReport.py > $os; then
>       echo "Unable to generate clean OSReport"
>       echo "Take a look at $os"

I think this is bad because if we later decide to re-order the
reports, make_environment_report() will nuke the report file in the
middle.  This should be done at the top level.

> @@ -280,5 +280,5 @@
>       echo "No such file: $XMLREPORT"
>       exit 1
>      fi
> -    submit_report $XMLREPORT
> -fi
> +    submit_report $XMLREPORT 
> +fi

Why is this hunk in your patch?

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

pgpFKcQJYPtlx.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel