WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Fix network connectivity problem in dom0 on Yona

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix network connectivity problem in dom0 on Yonah/Napa Platform
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Thu, 2 Mar 2006 18:29:14 -0800
Delivery-date: Fri, 03 Mar 2006 02:29:49 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcY+ZWOtiuqzyBseQCqxNCBL+jFO/AABH7QQ
Thread-topic: [Xen-devel] [PATCH] Fix network connectivity problem in dom0 on Yonah/Napa Platform
 
Resending with the same patch in the attachment.

Allen
________________________________

From: Kay, Allen M 
Sent: Thursday, March 02, 2006 5:54 PM
To: 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: [Xen-devel] [PATCH] Fix network connectivity problem in dom0 on
Yonah/Napa Platform



The original code only calls io_apic_get_unique_id() for P4 or earlier
processors by checking for CPU family < 15.  However, this check does
not apply to Yonah family of processors whose CPU family value is 6.
This caused io_apic_get_unique_id() being called in Xen but not in Dom0
since the code in Dom0 has been ifdef'ed out.  The end result is IOAPIC
ID mismatch between Xen and Dom0 - which caused IOAPIC not being
programmed at all.  This patch generalizes earlier code by checking for
LAPIC version number < 0x14 instead of CPU family - hence covers both P4
and new P6 family processors such as Yonah.

 

Signed-Off-By: Allen M. Kay <allen.m.kay@xxxxxxxxx>

 

diff -r 0807931dfa54 xen/arch/x86/mpparse.c

--- a/xen/arch/x86/mpparse.c    Fri Feb 24 15:37:09 2006

+++ b/xen/arch/x86/mpparse.c    Thu Mar  2 17:24:12 2006

@@ -935,7 +935,9 @@

        mp_ioapics[idx].mpc_apicaddr = address;

 

        set_fixmap_nocache(FIX_IO_APIC_BASE_0 + idx, address);

-       if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&
(boot_cpu_data.x86 < 15))

+       if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&

+               (GET_APIC_VERSION(apic_read(APIC_LVR)) < 0x14))

+

                mp_ioapics[idx].mpc_apicid = io_apic_get_unique_id(idx,
id);

        else

                mp_ioapics[idx].mpc_apicid = id;

Attachment: napa-net-380-ver05.patch
Description: napa-net-380-ver05.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>