WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] don't require ebtables in the host kernel

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] don't require ebtables in the host kernel
From: Avi Kivity <avi@xxxxxxxxxxxx>
Date: Wed, 22 Feb 2006 16:23:32 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 23 Feb 2006 10:53:42 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060222133334.GF28961@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43FC26DB.7060906@xxxxxxxxxxxx> <20060222133334.GF28961@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
Ewan Mellor wrote:

--- xen/tools/examples/network-bridge   (revision 991)
+++ xen/tools/examples/network-bridge   (revision 992)
@@ -158,9 +158,9 @@

   # Don't create the bridge if it already exists.
   if ! brctl show | grep -q ${bridge} ; then
-       sysctl -w "net.bridge.bridge-nf-call-arptables=0"
-       sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
-       sysctl -w "net.bridge.bridge-nf-call-iptables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-arptables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-iptables=0"
        brctl addbr ${bridge}
        brctl stp ${bridge} off
        brctl setfd ${bridge} 0

Where did this network-bridge script come from?  The stock Xen-3.0
network-bridge doesn't have these sysctl lines in the first place.
It comes from FC5. Sorry, should have checked the pristine Xen sources. Sorry about the noise.

Furthermore, using ! doesn't ignore the return value -- it inverts it.  I'd be
surprised if this works in systems that _do_ have ebtables.
No, ! on the beginning of a command tells bash to ignore the exit code:

   `-e'
         Exit immediately if a simple command (*note Simple
         Commands::) exits with a non-zero status, unless the command
         that fails is part of the command list immediately following
         a `while' or `until' keyword, part of the test in an `if'
         statement, part of a `&&' or `||' list, or if the command's
         return status is being inverted using `!'.  A trap on `ERR',
         if set, is executed before the shell exits.

'sysctl -ew' would have been better though.

--
error compiling committee.c: too many arguments to function


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>