Re: [Xen-devel] [PATCH] Repost - xm lists display and formatting

[Stefan Berger <stefanb@xxxxxxxxxx>]

dsteklof@xxxxxxxxxxxxxxxxxxxxxxx wrote on 02/17/2006
02:00:15 PM:

> On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > 
> > > This patch displays the network-list/block-list/vtpm-list
using the 'xm'
> > > command. It supports the '--long' option.
> > > 
> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> > 
> > Applied, thank you.
> > 
> > This will break xm-test.  Does anyone fancy fixing it up?
 The
> > least-effort thing to do is change all of the calls to block-list
and
> > network-list to become block-list --long and network-list --long,
but
> > it would be better if we fixed the eyecatchers (where necessary)
to work
> > with the new, formatted commands, and maybe added a few tests
for
> > xyz-list --long as well.
> > 
> > And of course it would be nice to have tests for vtpm-list (after
detecting
> > the presence of appropriate hardware, I guess).
> > 
> > Any volunteers?
> 
> 
> Hi,
> 
> Three comments:
> 
> 1) Changes like those introduced by this patch should be submitted
with
> corresponding tests in xm-test. We want to continue to use xm-test
to
> verify functionality.
> 
> 2) The documentation - like man pages - should be updated along with
the
> new functionality. 
> 
> 3) xm-test should be used to verify patches prior to submitting and
> applying. 

Sorry, I did not know about the dependency of this
tool on the output of this command.

  Stefan
> 
> Thanks,
> 
> Dan
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel