RE: [Xen-devel] X86_64 "assert" when booting 64-bit image.

["Petersson, Mats" <Mats.Petersson@xxxxxxx>]

> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
> Sent: 09 February 2006 16:03
> To: Petersson, Mats
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] X86_64 "assert" when booting 64-bit image.
> 
> 
> On 9 Feb 2006, at 15:48, Petersson, Mats wrote:
> 
> > My real question is, is the "assert" stuff in shadow.h:1222 
> valid? If 
> > it is valid, what is actually being checked?
> >
> > [yes, I have read the code, but I confess I don't understand enough 
> > about the internal workings of the shadow page-table to know what's 
> > going on in this bit of code].
> >
> > The code is based on XenSource changeset 8677:b721455c5e44.
> 
> That debug code is totally ancient. Ian may know whether it 
> has any relevance any more.

Thanks Keir. 

I #if 0'd out the test and it flies through the rest of the stuff until
the point where it got without debug. But I don't think the checking
code was added purely because it seemed fun to add in the first place,
so I'm still a bit concerned that it may actually be pointing at
something that causes a problem... Is it really safe to remove it?

--
Mats
> 
>   -- Keir
> 
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel