 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] make x86_64 vcpu hotplug work like i386
| To: | Ryan Grimm <grimm@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] make x86_64 vcpu hotplug work like i386 |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Wed, 8 Feb 2006 23:29:00 +0000 |
| Cc: | Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Wed, 08 Feb 2006 23:41:11 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20060208214331.GA827@xxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20060208214331.GA827@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 8 Feb 2006, at 21:43, Ryan Grimm wrote: the critical difference is that play_dead in arch/i386/process-xen.c andarch/x86_64/process-xen.c differ. the i386 version makes a VCPUOP_down call to the hypervisor while the x86_64 version schedules a SCHEDOP_yield among other things. plopping the i386 version (patch below) into x86_64/process-xen.c makes hotplugging in x86_64 behavior like i386. does anyone know why the x86_64 play_dead function is in the current state? Noone bothered to keep it in sync with the i386 version (and the 'common' hotplug changes in drivers/xen/core/smpboot.c). That would probably be my fault. :-) I've checked in a fixed up patch that still calls idle_task_exit(), and adds a call to it in i386's play_dead function, and also enables HOTPLUG_CPU in our x86_64 defconfigs. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] [BUG 447] Fix checksum errors when DNAT modifies port numbers, Keir Fraser |
|---|---|
| Next by Date: | RE: [Xen-devel] x86_64 eth0 e1000_clean_tx_irq tx hang, Ian Pratt |
| Previous by Thread: | [Xen-devel] [PATCH] make x86_64 vcpu hotplug work like i386, Ryan Grimm |
| Next by Thread: | Re: [Xen-devel] [PATCH] make x86_64 vcpu hotplug work like i386, Ryan Grimm |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
