WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen

To: Greg KH <greg@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date: Sat, 28 Jan 2006 13:23:35 +0100
Cc: "Mike D. Day" <ncmike@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, lkml <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Sat, 28 Jan 2006 12:32:49 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060128023828.GA20881@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43DAD4DB.4090708@xxxxxxxxxx> <20060128023828.GA20881@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Jan 27, 2006 at 06:38:28PM -0800, Greg KH wrote:
> > +
> > +int __init
> > +hyper_sysfs_init(void)
> > +{
> > +   int err ;
> > +   
> > +   if( 0 ==  (err = subsystem_register(&hypervisor_subsys)) ) {
> > +           xen_kset.subsys = &hypervisor_subsys;
> > +           err = kset_register(&xen_kset);
> > +   }
> 
> Is this the xen coding style?  If so, it's got to change before making
> it into mainline...  Please fix this up.

No, this is not coding style we use for linux related files.
The patch really need to be fix ...

-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel