WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [RFC] Is grant_read() runnable?

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [RFC] Is grant_read() runnable?
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Wed, 25 Jan 2006 17:13:32 +0900
Delivery-date: Wed, 25 Jan 2006 08:23:41 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, all

I think grant_read() is not runnable.
" (len > (PAGE_SIZE - 200)) " is not entered into if sentence 
becase of len=0.
So i always equal NR_GRANT_ENTRIES.

Is the below patch correct?
Please comment.

Best Regards,

Akio Takebe

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

diff -r a38c292e8390 linux-2.6-xen-sparse/arch/xen/kernel/gnttab.c
--- a/linux-2.6-xen-sparse/arch/xen/kernel/gnttab.c     Tue Jan 24 16:54:34 2006
+++ b/linux-2.6-xen-sparse/arch/xen/kernel/gnttab.c     Wed Jan 25 17:01:03 2006
@@ -361,22 +361,22 @@
        len = 0;
 
        for (i = 0; i < NR_GRANT_ENTRIES; i++) {
-               if (len > (PAGE_SIZE - 200)) {
+               if (len < (PAGE_SIZE - 200)) {
                        len += sprintf( page + len, "Truncated.\n");
                        break;
                }
-       }
-
-       if (gt[i].flags) {
-               len += sprintf(page + len,
-                              "Grant: ref (0x%x) flags (0x%hx) "
-                              "dom (0x%hx) frame (0x%x)\n", 
-                              i,
-                              gt[i].flags,
-                              gt[i].domid,
-                              gt[i].frame );
-       }
-
+
+               if (gt[i].flags) {
+                       len += sprintf(page + len,
+                                      "Grant: ref (0x%x) flags (0x%hx) "
+                                      "dom (0x%hx) frame (0x%x)\n", 
+                                      i,
+                                      gt[i].flags,
+                                      gt[i].domid,
+                                      gt[i].frame );
+               }
+
+       }
        *eof = 1;
        return len;
 }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>