WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make delaration and definition of xc_linux_save(

To: Horms <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make delaration and definition of xc_linux_save() the same
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2006 12:14:24 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 12 Jan 2006 12:21:00 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <dq4ups$c8q$1@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <dq4ups$c8q$1@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Jan 12, 2006 at 07:00:12AM +0000, Horms wrote:

> 8604:a51fcb5de470 introduced a discrepancy between the declaration
> and definition of xc_linux_save(). In particular the argument for
> the suspend pointer to function was null in one and int in the other.
> On inspection, int seemed to be correct, so I went with this.
> I also fixed up a few other cosmetic discrepancies.
> 
> Signed-Off-By: Horms <horms@xxxxxxxxxxxx>

Thanks.  I've applied this with s/fd_fd/io_fd, which is what I presume you
meant.

Ewan.


> 
> diff -r 1b89e2aed730 -r aa6c2e55dea5 tools/libxc/xc_ia64_stubs.c
> --- a/tools/libxc/xc_ia64_stubs.c     Thu Jan 12 04:05:05 2006
> +++ b/tools/libxc/xc_ia64_stubs.c     Thu Jan 12 06:54:59 2006
> @@ -23,7 +23,8 @@
>  }
>  
>  int xc_linux_save(int xc_handle, int io_fd, uint32_t dom, uint32_t 
> max_iters, 
> -                  uint32_t max_factor, uint32_t flags, int (*suspend)(void))
> +                  uint32_t max_factor, uint32_t flags /* XCFLAGS_xxx */, 
> +               int (*suspend)(int domid))
>  {
>      PERROR("xc_linux_save not implemented\n");
>      return -1;
> diff -r 1b89e2aed730 -r aa6c2e55dea5 tools/libxc/xenguest.h
> --- a/tools/libxc/xenguest.h  Thu Jan 12 04:05:05 2006
> +++ b/tools/libxc/xenguest.h  Thu Jan 12 06:54:59 2006
> @@ -21,9 +21,9 @@
>   * @parm dom the id of the domain
>   * @return 0 on success, -1 on failure
>   */
> -int xc_linux_save(int xc_handle, int fd, uint32_t dom, uint32_t max_iters, 
> +int xc_linux_save(int xc_handle, int fd_fd, uint32_t dom, uint32_t 
> max_iters, 
>                    uint32_t max_factor, uint32_t flags /* XCFLAGS_xxx */,
> -                  int (*suspend)(int));
> +                  int (*suspend)(int domid));
>  
>  
>  /**
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>