WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Getting and setting SEDF scheduling parameters

To: John L Griffin <jlg@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Getting and setting SEDF scheduling parameters
From: Stephan Diestelhorst <sd386@xxxxxxxxx>
Date: Thu, 12 Jan 2006 08:29:54 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 12 Jan 2006 07:36:09 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <OF56748F8E.8A763F25-ON852570ED.0068B675-852570ED.006AC522@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF56748F8E.8A763F25-ON852570ED.0068B675-852570ED.006AC522@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)
John L Griffin wrote:

This patch addresses three problems in the function sedf_adjdom():

3) The code logic in this function is cryptic, and there is not much documentation on how the scheduling parameters should be used. The attached patch adds comments to the sedf_adjdom() function, and reorders/rewrites the logic of the SCHED_INFO_PUT handling to make the code more self-documenting.
I know, the main problem is, that there are quite a number of different interpretations for some of the values, depending on the others. This caused some cryptic code as you point out properly, which I wasn't really happy with!

Stephan

Note that this patch makes strong assumptions about how the scheduling parameters are used. So, I recommend someone take a really close look at my comments to make sure I've preserved the Xen team's intentions for how the SEDF scheduler works. :-)

Signed-off-by: jlg@xxxxxxxxxx

------------------------------------------------------------------------

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>