 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [RFC] [PATCH] sysfs support for Xen attributes
| To: | "Mike D. Day" <ncmike@xxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [RFC] [PATCH] sysfs support for Xen attributes |
| From: | Dave Hansen <haveblue@xxxxxxxxxx> |
| Date: | Wed, 11 Jan 2006 10:45:26 -0800 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, lkml <linux-kernel@xxxxxxxxxxxxxxx> |
| Delivery-date: | Wed, 11 Jan 2006 18:51:55 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <43C53DA0.60704@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <43C53DA0.60704@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Wed, 2006-01-11 at 12:17 -0500, Mike D. Day wrote: > +#ifndef BOOL > +#define BOOL int > +#endif > + > +#ifndef FALSE > +#define FALSE 0 > +#endif > + > +#ifndef TRUE > +#define TRUE 1 > +#endif > + > +#ifndef NULL > +#define NULL 0 > +#endif Whatever you do with this driver, these need to go. Your patch is also whitespace-challenged. Why not make these Xen attributes part of the "system" devices? Seems a lot more natural to me. -- Dave _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | [Xen-devel] Re: [RFC] [PATCH] sysfs support for Xen attributes, Arjan van de Ven |
|---|---|
| Next by Date: | [Xen-devel] (XEN) (file=memory.c, line=42) Only I/O-capable domains may allocate multi-page extents., David F Barrera |
| Previous by Thread: | [Xen-devel] Re: [RFC] [PATCH] sysfs support for Xen attributes, Arjan van de Ven |
| Next by Thread: | [Xen-devel] Re: [RFC] [PATCH] sysfs support for Xen attributes, Mike D. Day |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
