xen-devel

[Top] [All Lists]

Re: [Xen-devel] pfn_pte/pfn_pmd

from [Jan Beulich]

[Permanent Link][Original]

To:	"Gerd Knorr" <kraxel@xxxxxxx>
Subject:	Re: [Xen-devel] pfn_pte/pfn_pmd
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Wed, 21 Dec 2005 16:34:02 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 21 Dec 2005 15:36:01 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<43A965F4.1010203@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<43A9401F.76F0.0078.0@xxxxxxxxxx> <43A94AE7.76F0.0078.0@xxxxxxxxxx> <43A965F4.1010203@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>> Gerd Knorr <kraxel@xxxxxxx> 21.12.05 15:25:56 >>>
>> I still wonder, however, whether the BUG()/panic() in PAE's
pfn_pmd()
>> couldn't be removed...
>
>Wonder why it is still in there though, seems pfn_pmd() is never ever

>used, checking code ...
>
>Ok, seems they are needed for 2M/4M pages, we don't support these 
>anyway, so BUG()'ing in case this is called looks perfectly fine.

I was about to think so, too, but I wasn't able to prove that the code
in arch/i386/mm/init-xen.c that uses it (and that is conditional upon
cpu_has_pse) can't get executed. Specifically, I missed
include/asm-i386/mach-xen/setup_arch_post.h clearing X86_FEATURE_PSE...


>The panic msg probably should be changed to something more reasonable,

>such as "Huh? Who tried to use 2M pages?" maybe ;)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] pfn_pte/pfn_pmd, Jan Beulich Re: [Xen-devel] pfn_pte/pfn_pmd, Jan Beulich Re: [Xen-devel] pfn_pte/pfn_pmd, Gerd Knorr Re: [Xen-devel] pfn_pte/pfn_pmd, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] Xen Kernel Freeze, Luke
Next by Date:	[Xen-devel] [patch, rfc] put IP addresses into xenstore, Gerd Knorr
Previous by Thread:	Re: [Xen-devel] pfn_pte/pfn_pmd, Gerd Knorr
Next by Thread:	[Xen-devel] Xen Kernel Freeze, Luke
Indexes:	[Date] [Thread] [Top] [All Lists]