xen-devel

[Top] [All Lists]

[Xen-devel] Re: [Xen-changelog] Work aroudn swiotlb issue where a read-o

from [Muli Ben-Yehuda]

[Permanent Link][Original]

To:	Keir Fraser <keir@xxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [Xen-changelog] Work aroudn swiotlb issue where a read-only host buffer is
From:	Muli Ben-Yehuda <mulix@xxxxxxxxx>
Date:	Sat, 17 Dec 2005 16:35:37 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Sat, 17 Dec 2005 14:38:05 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<E1EnbAV-0001gb-92@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<E1EnbAV-0001gb-92@xxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.11

On Sat, Dec 17, 2005 at 12:28:06PM +0000, Xen patchbot -unstable wrote:
> # HG changeset patch
> # User kaf24@xxxxxxxxxxxxxxxxxxxx
> # Node ID b92ca87a2403d465e4d1087f8a7a43223b21bed8
> # Parent  1509521c824efbae25bb953a2e2a49ab3f7fe7f4
> Work aroudn swiotlb issue where a read-only host buffer is
> mapped for DMA_BIDIRECTIONAL streaming access by certain
> low-level drivers. This causes an unnecessary copy to the
> host buffer that previously caused a fatal kernel page fault.

The fix (calling __copy_to_user on a kernelspace buffer) seems rather
awkward, and will probably make tools such as sparse faint in
horror. Wouldn't it make more sense to have the buffer mapped
read/write in the first place and/or fix the LLDD to not do
DMA_BIDIRECTIONAL? (I don't know which of these is correct; I suspect
the second?)

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] Re: [Xen-changelog] Work aroudn swiotlb issue where a read-only host buffer is, Muli Ben-Yehuda <= Re: [Xen-devel] Re: [Xen-changelog] Work aroudn swiotlb issue where a read-only host buffer is, Keir Fraser

Previous by Date:	[Xen-devel] [PATCH] avoid divide by zero exception, Ling, Xiaofeng
Next by Date:	[Xen-users] Debian DomU with physdev access init kernel crash ...., Himanshu Raj
Previous by Thread:	[Xen-devel] [PATCH] avoid divide by zero exception, Ling, Xiaofeng
Next by Thread:	Re: [Xen-devel] Re: [Xen-changelog] Work aroudn swiotlb issue where a read-only host buffer is, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]