| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] xencons missing string allocation
On 12 Dec 2005, at 22:00, Alex Williamson wrote:
You're right, but it's not quite that easy. I think we need some
consistency checking here. The point of this function seems to be
determining if the driver owns the device. If so, set the index and
return the driver, otherwise pass. I think the patch below does a
better job of solving the problem. When xc_num == c->index, the device
is the port xencons created, so the index is 0 and we claim it. The
only slightly complicated one is when using the tty devices c->index is
zero when xc_num is 1. I believe this does the right thing in all
cases, let me know what you think. Thanks,
What I would like to know is what the two index values actually mean.
:-) That is, what is c->index, and what is the index value that is
returned? Without knowing this I have no idea whether your patch is
correct or not. Is the expected behaviour of that console driver hook
function understood and/or documented?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home