[Xen-devel] compiler errors in latest unstable from 20051027

[Adam Heath <doogie@xxxxxxxxxxxxx>]

If CONFIG_SMP_ALTERNATIVES is selected, arch/xen/kernel/smpboot.c attempts to
include <asm/smp_boot.h>, which does not exist anywhere.  Which means
selecting that is not allowed.

However, there are several additional unprotected includes of that same file
in other places; include/asm-xen/asm-i386/system.h and
include/asm-xen/asm-i386/spinlock.h.

Plus, there is a complaint about LOCK not being defined in
include/asm-xen/asm/system.h.  If I add include <asm/atomic.h>, it gets by the
first such error, but then I get this later on:

==
In file included from include/asm-xen/asm/processor.h:18,
                 from include/asm/atomic.h:6,
                 from kernel/audit.c:45:
include/asm-xen/asm/system.h: In function `__cmpxchg':
include/asm-xen/asm/system.h:259: error: `LOCK' undeclared (first use in this
function)
==

This is because asm/system.h is being included recursively, so none of the
defines in asm/atomic.h are defined yet.

The steps I took to repeat this:

1: apt-get install lkinux-tree-2.6.12
2: /usr/src/kernel-patches/all/2.6.12/unpatch/debian 2.6.12
   # this gives a real 2.6.12 tree
3: cd linux-2.6-sparse
4: ./mkbuildtree $path_to_linux
   # this applies the 2.6.12.6 patch, then overlays the xen code on top of it.
5: create diff between xen-patched linux and plain 2.6.12.6
6: Go to another machine
7: extract 2.6.12, apply 2.6.12.6; no warnings from diff during this
8: apply xen patch; no warnings from diff during this
9: make menuconfig ARCH=xen
10: error as above


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel