On Tue, Nov 08, 2005 at 11:29:33AM +0000, Ewan Mellor wrote:
> On Mon, Nov 07, 2005 at 11:01:44AM -0800, Dan Smith wrote:
>
> > This patch removes all of the auto-generated files that were checked
> > in with xm-test in changeset 7634. It also adds an "autogen" script
> > that re-creates these files.
> >
> > The auto-generated files really don't need to be in the tree, as they
> > should be generated by the user on the machine where they plan to run
> > xm-test.
>
> I was in two minds about this one, as I have had discussions with others about
> this issue before. One the one hand, keeping generated files out of the tree
> is a good thing. On the other, this adds dependency upon autoconf and
> automake, which is something that we haven't had up 'til now. However, since
> xm-test will only be built at the explicit request of the user, I don't think
> that the burden of the autotools is too great, so I have applied the patch.
Right, though another way to think about checking in the autogenerated
files, is every change to the control (i.e. .am files) would require a
regenerated set of files by the person creating the checkin. The
autogenerated files are such, so might be slightly different (though
eqivalent) depending on the version of autotools used. This would create a
lot of patch noise in the repository, and might cause unexpected results.
-Sean
--
__________________________________________________________________
Sean Dague Mid-Hudson Valley
sean at dague dot net Linux Users Group
http://dague.net http://mhvlug.org
There is no silver bullet. Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________
pgpi4M0LdmJpF.pgp
Description: PGP signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home